Re: [libvirt] PATCH: 28/28: Remove unused param in QEMU monitor APIs
On Mon, Dec 01, 2008 at 12:25:17AM +0000, Daniel P. Berrange wrote:
The QEMU driver internal API for interacting with the monitor console
takes
a 'struct qemud_driver *' parameter. This is a problem because any access
to this struct must be protected by a lock, but we do not want to hold the
global driver lock for all monitor operations since it would destroy any
hope of concurrency. Fortunately tracing down many levels of call reveals
this parameter is totally unused, so this patch removes it from a tonne of
internal APIs
Okay, seems we're mostly just removing the driver parameter from most
calls, rather simple, we're lucky :-)
+1
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/