Re: [libvirt] [PATCH 03/18] util: storage: Don't force path canonicalization when loading metadata

>> - if (!(canonPath = canonicalize_file_name(path)) && >> - VIR_STRDUP(canonPath, path) < 0) { >> - virReportSystemError(errno, _("unable to resolve '%s'"), path); >> + if (virStorageIsFile(path)) { > > You are suggesting this same change in patch 6/18 ... as that patch > actually removes this code I'll leave this patch as-is and fix the code > in the new helper introduced in 6/18. Or I can squash those two commits together (effectively just mention the fix in the commit message).