23 Apr
2014
23 Apr
'14
12:07 p.m.
On 04/23/2014 01:59 AM, Peter Krempa wrote:
- if (!(canonPath = canonicalize_file_name(path)) && - VIR_STRDUP(canonPath, path) < 0) { - virReportSystemError(errno, _("unable to resolve '%s'"), path); + if (virStorageIsFile(path)) {
You are suggesting this same change in patch 6/18 ... as that patch actually removes this code I'll leave this patch as-is and fix the code in the new helper introduced in 6/18.
Or I can squash those two commits together (effectively just mention the fix in the commit message).
Squashing into one works for me. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org