[libvirt] Re: Patch to python-virtinst to allow it to choose svirt labels

Daniel J Walsh wrote: The patch didn't apply to latest upstream (there has been a lot of code movement recently). I rediffed the patch to apply against current tip, and made a few minor changes that don't change the overall result (mentioned below). This is already fixed upstream. You also had a minor bug fix in the Installer class that is fixed as well, so I dropped both pieces. I think this should really be at the management tool level (i.e, virt-manager). libvirt should be dumb in this respect, being passed a label via the xml and doing with it what it's told. I figure, virt-manager can have an option in Edit->Preferences, something like "Isolate virtual machines with SELinux". Defaults to on. If selinux isn't running, we disable the option with a tooltip explaining why (or maybe hide it altogether). If the option is enabled, virt-manager will assign labels to VMs at install time, and check all active connections to avoid label collisions. More advanced behavior can come later (assigning specific labels, some sort of collision resolution with VMs on new connections, etc.) Updated patch attached, I'll reply with patch specific comments later. Thanks, Cole