Re: [libvirt] [PATCH v2 4/5] domain: Define explicit flags for saved image xml

On 2/14/19 4:29 PM, Eric Blake wrote: > Commit d2a929d4 (0.9.4) defined virDomainSaveImageGetXMLDesc()'s use > of @flags as a subset of virDomainXMLFlags, documenting that 2 of the > 3 flags defined at the time would never be valid. Later, commit > 28f8dfdc (1.0.0) introduced a new flag, VIR_DOMAIN_XML_MIGRATABLE, but > did not adjust the save image documentation to declare it as invalid. > Later, commit a67e3872 (3.7.0) blindly copied and pasted the same text > into virDomainManagedSaveGetXMLDesc. >

> --- > include/libvirt/libvirt-domain.h | 5 +++++ > src/libvirt-domain.c | 14 ++++++-------- > src/qemu/qemu_driver.c | 4 ++-- > src/remote/remote_protocol.x | 4 ++-- > 4 files changed, 15 insertions(+), 12 deletions(-) > mea culpa and missa something that the subsequent patch points out ;-) The virDomainSaveImageGetXMLDesc and virDomainManagedSaveGetXMLDesc source code should use: if ((conn->flags & VIR_CONNECT_RO) && (flags & VIR_DOMAIN_SAVE_IMAGE_XML_SECURE)) { and not if ((conn->flags & VIR_CONNECT_RO) && (flags & VIR_DOMAIN_XML_SECURE)) {