Re: [PATCH] spec: Drop numad usage on fedora 39+

On 5/23/23 19:31, Cole Robinson wrote: > numad is removed from Fedora 39. Upstream is dead > > https://src.fedoraproject.org/rpms/numad/c/a6bb891e8447e3b2a4c63774da94ad... > https://pagure.io/releng/failed-composes/issue/4990#comment-857670 > > Signed-off-by: Cole Robinson <crobinso(a)redhat.com&gt; > --- > > This powers vcpu and numatune placement='auto'. Anyone know if that's > being actively used in kubevirt, openstack, etc? > > libvirt.spec.in | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index 1f77cd90b7..5f267a086b 100644 > --- a/libvirt.spec.in > +++ b/libvirt.spec.in > @@ -173,6 +173,10 @@ > %define with_numad 0%{!?_without_numad:1} > %endif > %endif > +%if 0%{?fedora} >= 39 > + # numad is retired in fedora 39+, upstream is dead > + %define with_numad 0 > +%endif Actually, it was just added back: https://pagure.io/releng/issue/11445 https://src.fedoraproject.org/rpms/numad/c/e0d0e47bbdabc8d915a61796e2e027... So maybe we will need to revert this? Or we may pretend that we never saw that and just carry on. I doubt numad had any users (I mean, from libvirt users group).

Michal