Re: [libvirt] [PATCH 2/2] maint: reject raw close, popen in 'make syntax-check'
On 01/28/2011 04:04 PM, Matthias Bolte wrote:
> +++ b/.x-sc_prohibit_close
> @@ -1,3 +1,9 @@
> +# Non-C files:
> ^docs/.*
> +^ChangeLog*
> ^HACKING$
> +*.py$
Shouldn't the dot be escaped here like in the other lines you added?
> +# Wrapper implementation:
> ^src/util/files.c$
And here too, although this one is pre-existing.
Sure. I'll fix that.
> +# Only uses close in documentation comments:
> +^src/libvirt\.c$
ACK, with that nit fixed.
It's minor, so I'm not posting my v2 of this patch. But obviously I
can't apply this until v2 of 1/2 is approved, since otherwise I would be
breaking 'make syntax-check'.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)