Re: [libvirt PATCH] util: remove virObjectUnref() adapters
On Thu, Jul 14, 2022 at 09:52:25AM -0500, Jonathon Jongsma wrote:
These wrapper functions were used to adapt the virObjectUnref()
function
signature for different callbacks. But in commit 0d184072, the
virObjectUnref() function was changed to return a void instead of a
bool, so these adapters are no longer necessary.
Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com>
---
This patch fails the build. The following needs to be squashed in:
diff --git a/src/util/virfilecache.c b/src/util/virfilecache.c
index c4bc984020..bad37c9f00 100644
--- a/src/util/virfilecache.c
+++ b/src/util/virfilecache.c
@@ -239,7 +239,7 @@ virFileCacheNew(const char *dir,
if (!(cache = virObjectNew(virFileCacheClass)))
return NULL;
- cache->table = virHashNew(virObjectFreeHashData);
+ cache->table = virHashNew(virObjectUnref);
cache->dir = g_strdup(dir);
Reviewed-by: Erik Skultety <eskultet(a)redhat.com>