Re: [libvirt] [PATCH] Solaris PV is localtime. Allow this setting through the conversions
On Thu, Jan 29, 2009 at 11:33:10AM +0000, Daniel P. Berrange wrote:
> + if (def->localtime && xenXMConfigSetInt(conf,
"localtime", 1) < 0)
> + goto no_memory;
Existing code unconditionally sets localtime=0 and localtime=1,
but this only sets localtime=1, relying on XM defaults for localtime=0.
I prefer not to rely on defaults when writing the config back out to disk
because those have a habit of being broken over time. Unconditionally
setting it avoids the need to change all those test case config files.
I was attempting to make it work consistently in all cases, and the
existing sexpr code doesn't write '(localtime 0)'. What would you
prefer?
regards
john