Re: [libvirt] [PATCH] Make really sure we don't access non-existing vCPUs
On Tue, Jul 12, 2016 at 06:24:01PM +0200, Peter Krempa wrote:
[...]
It might hint to readers that the array is indeed sparse. Reading the
code again I now think that rather than skipping the loop the check for
vcpu should be moved into the if right below it:
if (vcpu && vcpu->cpumask)
bitmap = vcpu->cpumask;
By skipping the loop you don't fill anything which is semanticaly wrong
in context of that function.
I pushed this version after our discussion about this. I can start
watching the CI mails again ;)
Martin
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)