Re: [libvirt] RFC: APIs to manage KSM
On Fri, Aug 31, 2012 at 07:54:31AM -0700, Eric Blake wrote:
On 08/31/2012 07:46 AM, Daniel P. Berrange wrote:
> On Fri, Aug 31, 2012 at 04:56:01PM +0800, Osier Yang wrote:
>> Triggered by the requirement to control the new sys knob
>> /sys/kernel/mm/ksm/merge_nodes for a NUMA aware host by
>> patch:
>>
>
> As a general point, we should not use the term 'KSM' in the API
> names, since that is an implementation specific name. We want
> some more generic name. eg
>
> virNodeSetMemorySharingParameters
>
> likewise for all the enum/constant names.
For that matter, why can't we reuse the existing
virDomainSetMemoryParameters() for the enum/constants? That is, whether
or not to use ksm is a memory parameter.
Actually this is a host level action. There is a separate non-upstreamed
patch which lets us control whether KSM is used per-guest, which is waiting
for a fix to QEMU
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|