On 09.01.2014 09:22, Martin Kletzander wrote:
This is basically v3 of the patch Pavel Fux sent [1] with the addition of changing the default as discussed in the same thread [2].
Martin
[1] https://www.redhat.com/archives/libvir-list/2014-January/msg00060.html [2] https://www.redhat.com/archives/libvir-list/2014-January/msg00367.html
Martin Kletzander (1): qemu: Change the default unix monitor timeout
Pavel Fux (1): qemu: Add support for changing timeout value to open unix monitor socket
src/qemu/libvirtd_qemu.aug | 3 +++ src/qemu/qemu.conf | 12 ++++++++++++ src/qemu/qemu_conf.c | 2 ++ src/qemu/qemu_conf.h | 2 ++ src/qemu/qemu_monitor.c | 20 +++++++++++++++++--- src/qemu/test_libvirtd_qemu.aug.in | 1 + 6 files changed, 37 insertions(+), 3 deletions(-)
-- 1.8.5.2
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
I'm not going to ACK these until there's an agreement upstream, but just to express my opinion: I like these patches. I'm not sure about qemu internals, but I see some cases where this might be handy: a) qemu access anything on the disk prior to creating the eventloop thread (and thus accept()-ing us on the monitor). The file qemu's accessing might be on an NFS which is currently unresponsive. Either it will be back in a while and then we can allow domain startup, or it won't - then we need to kill the qemu. And what does 'while' mean is use case specific => should be configurable. b) system is temporarily under heavy load - e.g. I/O load - which means, kernel is not able to link and preload qemu and its libraries. Michal