Re: [PATCHv2 2/5] qemu_capabilities: Add support for nvme-ns bus capabilities

On Sun, Apr 27, 2025 at 19:48:04 +0800, honglei.wang(a)smartx.com wrote: Generally patches adding a capability flag should only add the capability flag. Thus you'll need to split this patch. 1) capability addition - move it ahead to the beginning of the series (doing that will allow you to do capability checks when adding the code instead when adding the capability - note the full flag name (QEMU_CAPS...) in the summary line of the commit message 2) domain caps addition - that ought to be done after the code addition is compelete, thus after you add the XML schema bits and implementation All of the above is suspicious. The test files were forgotten after we dropped support for the qemu versions mentioned in them. How did you modify these? Interestingly there are more of the files for unsupported versions but you didnt modify all of them. Anyways I'll send a patch deleting those. The rest of the patch looks good but most of the code additions will need to be moved to corresponding patches.