Re: [libvirt] [PATCHv2 1/3] conf: Split out code to parse the source of a disk definition

On 11/07/2013 11:16 AM, Peter Krempa wrote:

To avoid code duplication between snapshot configuration code that parses the disk source too we need to split out this code that will be reused later on.

This patch tries to be code movement, some aspects of this function will be refactored later. ---

Notes: Version 2: - move operations on "protocol" and "protocol_transport" to the new function - set expected_secret_usage only if disk is of type NETWORK

src/conf/domain_conf.c | 266 +++++++++++++++++++++++++++---------------------- 1 file changed, 149 insertions(+), 117 deletions(-)

ACK