Re: [libvirt] [PATCH] Promote storage pool refresh lifecycle event to top level event
On 06/24/2016 12:38 PM, Daniel P. Berrange wrote:
The VIR_STORAGE_POOL_EVENT_REFRESHED constant does not
reflect any change in the lifecycle of the storage pool.
It should thus not be part of the storage pool lifecycle
event set, but rather be a top level event in its own
right. Thus we introduce VIR_STORAGE_POOL_EVENT_ID_REFRESH
to replace it.
Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
---
NB this breaks API and wire protocol, so we *must*
include this before 2.0.0. Ideally we should get it
into before we cut any rc release too.
ACK, I didn't see anything wrong here.
I don't think any libvirt-python changes are needed either since this is using
the same generic callback, except tweaking event-test.py which isn't time
critical. Sorry for the last minute rush...
As an aside, I've been talking with Jovanka adding nodedev events. Nodedevs
don't really have a traditional lifecycle like other objects. It's really only
added, removed, updated. I guess for typical objects that would basically be
added=DEFINED, removed=UNDEFINED, updated=DEFINED, but it's a little weird
given that we have define/undefine APIs here. Any suggestion here? Stick with
'Lifecycle' naming and DEFINED/UNDEFINED events, or something else?
Thanks,
Cole