Re: [libvirt] [PATCH] esx: Convert autoAnswer from esxVI_Boolean to a simple bool

Just true/false is good enough for it. Also use it directly from the parsed URI instead of caching it in esxPrivate. --- src/esx/esx_driver.c | 52 ++++++++++++++++++++--------------------- src/esx/esx_private.h | 1 - src/esx/esx_storage_driver.c | 12 ++++++--- src/esx/esx_vi.c | 15 +++++------ src/esx/esx_vi.h | 8 +++--- 5 files changed, 44 insertions(+), 44 deletions(-) +++ b/src/esx/esx_private.h @@ -41,7 +41,6 @@ typedef struct _esxPrivate { int32_t maxVcpus; esxVI_Boolean supportsVMotion; esxVI_Boolean supportsLongMode; /* aka x86_64 */ - esxVI_Boolean autoAnswer; int32_t usedCpuTimeCounterId; } esxPrivate;

+++ b/src/esx/esx_vi.c @@ -2482,7 +2482,7 @@ int esxVI_LookupVirtualMachineByUuidAndPrepareForTask (esxVI_Context *ctx, const unsigned char *uuid, esxVI_String *propertyNameList, esxVI_ObjectContent **virtualMachine, - esxVI_Boolean autoAnswer) + bool autoAnswer)