On 07/26/2013 06:29 AM, Daniel P. Berrange wrote:
>> This should probably go in for 1.1.1, but it's not a
build-breaker
>> so it needs review.
Glad I waited for a review.
>
> Not sure this approach to finding libgnutls.so is going to work
> reliably. eg, we allow --with-gnutls=/some/dir to point to
> say /usr/local, or /opt/gnutls.
>
> Also with pkg-config, the library can be located basically
> anywhere in the filesystem
>
> Gnutls had a hard cutover point from gcrypt to nettle
> in the 3.0.0 release. So could we just check the
> GNUTLS_VERSION_MAJOR value >= 3 in the header ?
Oh, actually we don't even need todo that. We can rely on pkgconfig
Good idea; I'll post a v2.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org