On Mon, Apr 23, 2018 at 02:44:57PM +0200, Martin Kletzander wrote:
Let's make a rule out of it and document it. This is based on
few sources:
1) Most of the code [1] used spaces after casts, so the patch to change it this
way rather than the other way around is smaller
2) I asked the first libvirt developer on my left when deciding, they preferred
spaces
3) My own preference.
4) The fact that this is clearly the superior way of casting =D
[1] 54.85% is more than 50%, plus it is increasing as it was 52.96% during the
first draft of this clean-up.
I'm surprised that is the case, but if you'll show the command you used to
extract that stat I could be convinced...
Personally I'm not a fan of adding the extra space - the cast is associated
with the variable, so I don't think it needs it.
Regards,
Daniel
--
|:
https://berrange.com -o-
https://www.flickr.com/photos/dberrange :|
|:
https://libvirt.org -o-
https://fstop138.berrange.com :|
|:
https://entangle-photo.org -o-
https://www.instagram.com/dberrange :|