Re: [libvirt PATCH 09/30] qemu_block: introduce qemuBlockFinalize
On Thu, Dec 08, 2022 at 14:30:45 +0100, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
src/qemu/qemu_block.c | 19 +++++++++++++++++++
src/qemu/qemu_block.h | 5 +++++
2 files changed, 24 insertions(+)
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index 2abddf904f..24c82377b0 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -3509,3 +3509,22 @@ qemuBlockPivot(virDomainObj *vm,
return ret;
}
+
+
While at the monitor level it's quite obvious here please add a comment
and describe what the finalization step actually is and how it's
supposed to be used.
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>