On 05/04/2011 08:45 AM, Jiri Denemark wrote:
--- src/driver.h | 5 +++++ src/esx/esx_driver.c | 1 + src/libxl/libxl_driver.c | 1 + src/lxc/lxc_driver.c | 1 + src/openvz/openvz_driver.c | 1 + src/phyp/phyp_driver.c | 1 + src/qemu/qemu_driver.c | 1 + src/remote/remote_driver.c | 1 + src/test/test_driver.c | 1 + src/uml/uml_driver.c | 1 + src/vbox/vbox_tmpl.c | 1 + src/vmware/vmware_driver.c | 1 + src/xen/xen_driver.c | 1 + src/xen/xen_driver.h | 1 + src/xen/xen_hypervisor.c | 1 + src/xen/xen_inotify.c | 1 + src/xen/xend_internal.c | 1 + src/xen/xm_internal.c | 1 +
Hmm, I don't think we should be modifying the _xenUnifiedDriver internal callback struct in xen_driver.h, nor all the internal xen users. Rather, adding the new member to xen_driver.c should be enough to cover the code, since the stated goal in xen_driver.h is to eventually get rid of the internal callback struct and make xen_driver directly call into the appropriate helpers as necessary.
typedef int + (*virDrvDomainGetState) (virDomainPtr domain, + int *state, + int *reason);
This will obviously change according to whatever API we settle on in patch 1. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org