Re: [libvirt] [PATCH v2 1/4] virNetDevBridgeGet: Don't require users to virNetDevSetupControl

On Thu, Jun 02, 2016 at 12:42:50 +0200, Michal Privoznik wrote:

So far, this function has just three callers. Two of them call virNetDevSetupControl to create a socket that we can then optionally use for ioctl() to fetch data. However, querying sysfs is preferred. Therefore it doesn't make much sense to require users to set up the socket if they don't even know it will be used in favour of sysfs. We can set up the socket iff we need to.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/util/virnetdevbridge.c | 35 ++++++++++++----------------------- 1 file changed, 12 insertions(+), 23 deletions(-)

ACK, this version is much much cleaner. Thanks for fixing this properly.