Re: [PATCH RESEND v3 8/8] libvirt.spec: drop no longer required build dependencies
On 5/25/21 12:00 PM, Andrea Bolognani wrote:
On Tue, May 25, 2021 at 10:00:47AM +0200, Pavel Hrdina wrote:
> -# For mount/umount in FS driver
> -BuildRequires: util-linux
This BuildRequires is duplicated, so please drop the other instance
as well.
> -# For storage wiping with different algorithms
> -BuildRequires: scrub
Turns out we're actually missing the runtime dependency on scrub! Can
you please take care of addressing that issue in a separate patch?
Are we? scrub is needed if and only if you want to pass a special
algorithm to virStorageVolWipePattern(). Does that justify a runtime
dependency? We fail gracefully if scrub isn't installed. We aren't even
requiring qemu binary for daemon-driver-qemu package.
Wasn't the whole idea to drop dependencies?
Michal