On 05/27/2011 04:12 AM, Daniel P. Berrange wrote:
But anything is better than nothing, so I won't give any further complaints if we go with your idea of only annotating the exceptions to the 'long long' default, rather than all uses of hyper.
My rationale for defaulting to 'long long' is that we should never add any more APIs which take a plain 'long' anywhere. It would be a nice idea if we could get apibuild.py or something to raise an error if it finds any more APIs using 'long', except for a whitelist of existing ones
Yes, I like that compromise. Default to 'long long', enforce that default in new code, and whitelist the old exceptions; then we only have to annotate the exceptions, and don't have to worry about adding annotations when adding new API. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org