Yeah, this is a big change. However, it's needed. Indenting by
TABs leads to more headache and the sooner we do this the better.
I've pushed the patches to my github too:
https://github.com/zippy2/libvirt-php/commits/fixes
Maybe we should introduce a syntax-check rule too. BUT - there's
no gnulib submodule (which introduction would be another
headache, so I'm okay with leaving that as an exercise for
somebody else).
Now, I realize there's not much reviewer's bandwidth, so what if
I just give you guys some time, and if there's no review in say a
week or two, I'll go ahead and push this?
Oh, and for better viewing of the patches use
--ignore-space-change. That cuts off any space change and leave
you with just interesting changes.
Michal Privoznik (7):
sockets.c: :retab
vncfunc.c: :retab
libvirt-php.c: :retab
libvirt-php.h: :retab
generate-api-docs.c: :retab
generate-api-docs: Adapt to new comments style
libvirt_stream_close: Pass the actual connect object
src/libvirt-php.c | 13598 ++++++++++++++++++++++----------------------
src/libvirt-php.h | 244 +-
src/sockets.c | 353 +-
src/vncfunc.c | 1397 +++--
tools/generate-api-docs.c | 457 +-
5 files changed, 8028 insertions(+), 8021 deletions(-)
--
2.3.6