
Eric Blake <eblake@redhat.com> writes:
On 08/19/2013 01:22 PM, Doug Goldstein wrote:
Or potentially generic-ify this a bit more to make it like a virConnectHypervisorCapabilities() where right now it just returns back the CPUs the HV can emulate. In the future it can have support for other things if we need it to.
Listing all the capabilities of all the emulators in the existing virConnectHypervisorCapabilities may be too much XML for one RPC call; so a new API that lets us focus on one particular emulator is worthwhile. But yes, this is a better scheme to be copying from - we want a command where the user specifies an emulator, and the output is XML describing that emulator's capabilities according to what libvirt can expose.
thank you both for the input. I will rename the new function to virConnectGetHypervisorCapabilities and add a flags argument that controls what capabilities are included in the XML; for now both _ALL and _CPUS will return the same XML. Giuseppe