On 2/15/23 11:41, Andrea Bolognani wrote:
Motivation for these changes can be found in the commit message
for patch 20 ("qemu: Move firmware selection from startup to
postparse") as well as [RHBZ#2161965].
Patches 01-17 are preparatory fixes/improvements/cleanups.
Patches 19-20 move firmware selection from startup to postparse,
and patches 21-22 clean up a bit after that change. Patch 20 in
particular is significantly larger than I would have liked, but
I haven't been able to come up with a way to split it while
still preserving bisectability and making things clearer instead
of complicating them. If anyone has ideas in this regard, please
let me know!
Patches 23-27 add support for choosing a firmware format, but
are effectively no-op because formats other than raw are still
rejected at this point.
Patches 28-30 add support for QCOW2 format firmware in the QEMU
driver.
Patches 31-33 document the changes.
[RHBZ#2161965]
https://bugzilla.redhat.com/show_bug.cgi?id=2161965
Andrea Bolognani (33):
docs: Fix documentation for loader.stateless attribute
tests: Set nvramDir in qemuxml2xmltest
tests: Rename firmware-manual-efi-rw* tests
tests: Use x86_64 for all x86 firmware tests
tests: Move firmware tests to CAPS_LATEST
tests: Unify input files for firmware tests
tests: Enable qemuxml2xml for more firmware tests
tests: Add more firmware tests
qemu: Introduce qemuDomainDefMachinePostParse()
qemu: Introduce qemuDomainDefBootPostParse()
conf: Introduce virDomainLoaderDefParseXMLLoader()
conf: introduce virDomainLoaderDefNew()
qemu: Add convenience local variables
qemu: Only fill nvramTemplate for local sources
qemu: Clear os.firmwareFeatures after autoselection
qemu: Don't pick firmware that requires SMM when smm=off
qemu: Don't pick firmware with unsupported format
tests: Add descriptors for QCOW2 format firmware builds
conf: Export virDomainDefOSValidate()
qemu: Move firmware selection from startup to postparse
qemu: Move qemuDomainNVRAMPathFormat() to qemu_firmware
qemu: Introduce qemuFirmwareEnsureNVRAM()
conf: Change handling for empty NVRAM path
conf: Parse firmware format
drivers: Reject unsupported firmware formats
qemu: Filter firmwares based on format
qemu: Propagate firmware format
conf: Accept QCOW2 firmware format
qemu: Add support for QCOW2 format firmware
tests: Add more firmware tests
docs: Document firmware format attribute
news: Document changes to firmware autoselection
news: Document support for QCOW2 format firmware
160 files changed, 1408 insertions(+), 990 deletions(-)
You'll need to rebase these, sorry for late review.
Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com>
Michal