On 02/13/2014 09:49 AM, Peter Krempa wrote:
Use the new storage driver APIs to delete snapshot backing files in case of failure instead of directly relying on "unlink". This will help us in the future when we will be adding network based storage without local representation in the host. ---
Notes: Version 6: - simplified as the storage driver now doesn't require "conn"
+++ b/cfg.mk @@ -764,6 +764,7 @@ sc_prohibit_cross_inclusion: cpu/ | locking/ | network/ | rpc/ | security/) \ safe="($$dir|util|conf)";; \ xenapi/ | xenxs/ ) safe="($$dir|util|conf|xen)";; \ + qemu/ ) safe="($$dir|util|conf|cpu|network|locking|rpc|security|storage)";; \ *) safe="($$dir|util|conf|cpu|network|locking|rpc|security)";; \
We could probably add storage as safe for ALL drivers to use, not just qemu; but I'm okay with the approach you took. ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org