[PATCH 2/2] network: Suppress reporting an error when D-Bus is unavailable in networkStateInitialize()

From: Michal Privoznik <mprivozn(a)redhat.com&gt; When the network driver initializes itself, it tries to subscribe to signals from Firewalld sent over system D-Bus. Well, the code is written in best effort mode, i.e. lack of D-Bus is not considered an error. Problem is, virGDBusGetSystemBus() which is used to obtain system D-Bus prints out an error in case of lacking system D-Bus. This pollutes the logs (which may mislead users) and goes against the best-effort nature of aforementioned code. Check for the system D-Bus presence via virGDBusHasSystemBus() first. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; --- src/network/bridge_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 2cad1c8cbe..34b655e816 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -710,7 +710,8 @@ networkStateInitialize(bool privileged, network_driver->networkEventState = virObjectEventStateNew(); #ifdef WITH_FIREWALLD - if (!(sysbus = virGDBusGetSystemBus())) { + if (!virGDBusHasSystemBus() || + !(sysbus = virGDBusGetSystemBus())) { VIR_WARN("DBus not available, disabling firewalld support " "in bridge_network_driver: %s", virGetLastErrorMessage()); } else { -- 2.49.0