Re: [libvirt] [PATCH 1/2] python: treat flags as default argument with value 0
On 03/21/2013 04:47 AM, Osier Yang wrote:
On 2013年03月21日 16:41, Guannan Ren wrote:
> The following four functions have not changed because default arguments
> have to come after positional arguments. Changing them will break the
> the binding APIs.
>
> migrate(self, dconn, flags, dname, uri, bandwidth):
> migrate2(self, dconn, dxml, flags, dname, uri, bandwidth):
> migrateToURI(self, duri, flags, dname, bandwidth):
> migrateToURI2(self, dconnuri, miguri, dxml, flags, dname, bandwidth):
So how are they filtered? ...
They are not generated; this patch adds a default to all generated
functions, then adds a default to all hand-written functions except for
those four.
All the left are manually created files. So it's safe.
I agree, and since I had been asking for this,
ACK.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)