Re: [libvirt] [libvirt-glib] Add gvir_storage_vol_resize()
On Wed, Feb 1, 2012 at 1:03 PM, Christophe Fergeau <cfergeau(a)redhat.com> wrote:
On Wed, Feb 01, 2012 at 02:27:28AM +0200, Zeeshan Ali (Khattak)
wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak(a)gnome.org>
> + GError **err)
> +{
> + GVirStoragePoolInfo* pool_info = NULL;
> + GVirStorageVolInfo* volume_info = NULL;
> + gboolean ret = FALSE;
> +
> + pool_info = gvir_storage_pool_get_info (vol->priv->pool, err);
> + if (err != NULL && *err != NULL)
> + goto cleanup;
> + volume_info = gvir_storage_vol_get_info (vol, err);
> + if (err != NULL && *err != NULL)
> + goto cleanup;
What are pool_info and volume_info used for?
Oh, I forgot to remove those. I also forgot to correct the return value docs.
Rest of the patch is straightforward, so ACK once libvirt 0.9.10
(11?) is
released. Don't forget to update the libvirt requirement in configure.ac
if you're the first one to commit something depending on this new release.
Oh yes, i forgot that too. :)
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124