Re: [libvirt] [PATCH] virnetdevtap: Don't check for flags in virNetDevTapCreateFlags
On 03/30/2012 05:49 AM, Michal Privoznik wrote:
With latest gnulib we are checking even the lowest level functions
whether they check flags. Moreover, we are shadowing the real error
on system without TUNSETIFF support.
---
cfg.mk | 2 +-
src/util/virnetdevtap.c | 5 +----
2 files changed, 2 insertions(+), 5 deletions(-)
@@ -241,7 +239,6 @@ int virNetDevTapCreate(char **ifname
ATTRIBUTE_UNUSED,
int *tapfd ATTRIBUTE_UNUSED,
unsigned int flags)
Missing the ATTRIBUTE_UNUSED here. ACK with that fix.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)