Re: [libvirt] [PATCH] tests: Set abs_*dir in a consistent way
On 03/19/2014 07:50 AM, Jiri Denemark wrote:
Use $(shell cd $(...) && pwd) to set abs_*dir variables
similarly to
what src/Makefile.am does.
Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
---
tests/Makefile.am | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
AM_CFLAGS = \
- -Dabs_builddir="\"`pwd`\"" \
- -Dabs_srcdir="\"`cd '$(srcdir)'; pwd`\"" \
+ -Dabs_builddir="\"$(abs_builddir)\"" \
+ -Dabs_srcdir="\"$(abs_srcdir)\"" \
A little shorter as -Dabs_builddir='"$(abs_builddir)"', but works
as-is.
-lv_abs_top_builddir=`cd '$(top_builddir)'; pwd`
+lv_abs_top_builddir=$(shell cd '$(top_builddir)'; pwd)
While touching this, s/;/&&/ to match the abs_srcdir setting.
ACK with that tweak.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)