Re: [libvirt] [PATCH v3 20/28] conf: Add target type and model for pl011
On Mon, 2017-11-27 at 17:05 +0100, Pavel Hrdina wrote:
One thing that I've just realized is that there is no capability
check
whether that device exists. In QEMU it's configurable so there can
be QEMU compiled without this device, however, by default it's enabled.
I would compare it to the isa-serial, in most cases it will be enabled
by default so there is no need to have the capability check but since
you are adding that check, you can add this one as well, or drop the
isa-serial capability check :).
Yeah, having a capability for isa-serial, spapr-vty and pl011 is
arguably kind of overkill because they will always be compiled into
the QEMU binary for the corresponding architecture... On the other
hand I don't like the idea of using functionality without checking
for its presence first, so I'll add a capability for pl011 too :)
--
Andrea Bolognani / Red Hat / Virtualization