Re: [libvirt] [PATCH v13 00/49] write separate module for hostdev passthrough

On Mon, Mar 03, 2014 at 05:57:31PM +0100, Cedric Bosdonnat wrote: > Hello ChunYan, > > I saw a few minor problems in some patches that made me rebase quite a > lot of other patches in your serie, but otherwise it really looks good > to me. > > Here is a summary of the changes I made or questions I have: > * Patch 2: Fixed a few remaining changes that broke the build. > Just remember that having the tree building after each commit > helps a lot when one later needs to bisect. > * Patch 4: when is the manager freed? > * Patch 5 & 6: remove the added ATTRIBUTE_UNUSED > * Patch 9: added { } around if block to match else style. > * Patch 10: remove added ATTRIBUTE_UNUSED > * Patch 11: fixed indent function rename > * Patch 42: Fix comment about qemuPrepareHostdevPCIDevices in > earlier patch > * Patch 47: remove added ATTRIBUTE_UNUSED > * Patch 49: Fixed the version in libxl_driver.c as 1.2.2 is out > > The whole updated patch series is sitting here for those wanting to see > the changes applied: > https://github.com/cbosdo/libvirt/commits/hostdev-passthrough > > Of course, I'ld love another pair of sharper eyes to look at the patch > series. I'm not an expert on the hostdev topic ;) Thanks for posting that. I'm going to start reviewing this series and aim to push as many patches as practical todo so. This is a good time in the release cycle to get such a big change into the tree.