On Wed, 2016-04-06 at 12:17 +0200, Jiri Denemark wrote:
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 03e2438..fdea12a 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -77,7 +77,11 @@
>
> %if 0%{?rhel}
> %define with_qemu_tcg 0
> - %define qemu_kvm_arches x86_64
> + %if 0%{?rhel} >= 7
> + %define qemu_kvm_arches x86_64 %{power64}
> + %else
> + %define qemu_kvm_arches x86_64
> + %endif
> %endif
>
> %ifarch %{qemu_kvm_arches}
%if 0%{?rhel}
%define with_qemu_tcg 0
%define qemu_kvm_arches x86_64
+ %if 0%{?rhel} >= 7
+ %define qemu_kvm_arches x86_64 %{power64}
+ %endif
%endif
%ifarch %{qemu_kvm_arches}
Would be better since it makes adding new releases easier. See, e.g.,
how it looks nice and clear for fedora:
%if 0%{?fedora}
%if 0%{?fedora} < 16
# Fedora doesn't have any QEMU on ppc64 until FC16 - only ppc
# I think F17 is the first release with the power64 macro
%ifarch ppc64
%define with_qemu_tcg 0
%endif
%endif
%if 0%{?fedora} >= 18
%define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x
%endif
%if 0%{?fedora} >= 20
%define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %{arm} aarch64
%endif
%endif
Yeah, it does look better.
So can I amend the commit with your proposed version
and push it?
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team