Re: [libvirt] [PATCHv5 1/3] Allow <source> for type=block to have no dev

On 09/17/2013 07:44 AM, Doug Goldstein wrote:

Currently the XML parser already allows the following syntax: <disk type='block' device='cdrom'> <source startupPolicy='optional'/> <target dev='hda' bus='ide'/> <address type='drive' controller='0' bus='0' target='0' unit='0'/> </disk>

But it if the dev value then it would not have the leading "<source ",

s/value/value is NULL,/

resulting in invalid XML. --- docs/schemas/domaincommon.rng | 8 +++++--- src/conf/domain_conf.c | 4 ++-- 2 files changed, 7 insertions(+), 5 deletions(-)

ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org