On Wed, Feb 24, 2010 at 03:51:39PM +0000, Daniel P. Berrange wrote:
I think SIGWINCH + SIGCHLD + SIGPIPE are a reasonably set to block since those are common "normal" signals a process may received during operation. Other signals are all typically related to fatal problems rather tha normal conditions
This updated patch includes masking of SIGCHLD and SIGPIPE as well. I tested this patch with virt-top. Another potential change would be to use ppoll(2) instead of poll(2). However I don't think this gives us any extra safety. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://et.redhat.com/~rjones/libguestfs/ See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html