Re: [libvirt] [PATCH v6 REBASE 3/5] vz: implement managed migration
On 17.05.2016 21:33, Maxim Nestratov wrote:
22.04.2016 10:20, Nikolay Shirokovskiy пишет:
> The newest version of migration protocol - version 3 with parameters is implemented.
> Supported flags is VIR_MIGRATE_PAUSED only. Supported parameters are
> VIR_MIGRATE_PARAM_URI and VIR_MIGRATE_PARAM_DEST_NAME. VIR_MIGRATE_PARAM_DEST_XML
> is in VZ_MIGRATION_PARAMETERS for technical onyl reasons.
>
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com>
> ---
> src/vz/vz_driver.c | 444 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> src/vz/vz_sdk.c | 42 +++++
> src/vz/vz_sdk.h | 6 +
> 3 files changed, 492 insertions(+)
>
...
ACK as a starting point with comments inline.
But we certaintly should improve the implementation by making it asynchonous.
Great. I'll fix all the minor issues then.