Re: [libvirt] [PATCH v5 04/20] backup: Introduce virDomainCheckpointPtr
On 3/7/19 12:47 AM, Eric Blake wrote:
Prepare for introducing a bunch of new public APIs related to
backup checkpoints by first introducing a new internal type
and errors associated with that type. Checkpoints are modeled
heavily after virDomainSnapshotPtr (both represent a point in
time of the guest), although a snapshot exists with the intent
of rolling back to that state, while a checkpoint exists to
make it possible to create an incremental backup at a later
time.
Signed-off-by: Eric Blake <eblake(a)redhat.com>
---
v5: minor review tweaks [John]
---
include/libvirt/virterror.h | 6 +++-
src/util/virerror.c | 12 ++++++-
include/libvirt/libvirt.h | 6 +++-
src/datatypes.h | 31 +++++++++++++++++-
src/datatypes.c | 63 ++++++++++++++++++++++++++++++++++++-
src/libvirt_private.syms | 2 ++
6 files changed, 115 insertions(+), 5 deletions(-)
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John
I think this is also separable....
I will stop here since it seems the rest could/would have changes based
on other snapshot series posted, in various states of review, and being
pushed. Mainly trying to clear a bit of the "future" queue ;-)