On 09/29/2011 06:22 PM, Eric Blake wrote:
Although the compiler wasn't complaining (since it was the
pointer,
rather than what was being pointed to, that was actually const), it
looks quite suspicious to call a function with an argument labeled
const when the nature of the pointer (virBufferPtr) is hidden behind
a typedef. Dropping const makes the function declarations easier
to read.
* src/util/buf.h: Drop const from all functions that modify buffer
argument.
* src/util/buf.c (virBufferSetError, virBufferAdd)
(virBufferContentAndReset, virBufferFreeAndReset)
(virBufferAsprintf, virBufferVasprintf, virBufferEscapeString)
(virBufferEscapeSexpr): Fix fallout.
---
ACK, but be careful while rebasing to current head.
Some new functions were added recently to buf.[ch] and you'll
get a nasty conflict on buf.h. (Dont forget to merge virBufferEscape)
Peter