Re: [libvirt] PATCH: Support initial boot time CPU affinity mask

On Fri, May 16, 2008 at 10:50:20PM +0100, Daniel P. Berrange wrote: > + /* Extract domain vcpu info */ > + obj = xmlXPathEval(BAD_CAST "string(/domain/vcpu[1]/@cpuset)", ctxt); > + if ((obj == NULL) || (obj->type != XPATH_STRING) || > + (obj->stringval == NULL) || (obj->stringval[0] == 0)) { > + /* Allow use on all CPUS */ > + memset(def->cpumask, 1, QEMUD_CPUMASK_LEN); > + } else { > + char *set = (char *)obj->stringval; > + memset(def->cpumask, 0, QEMUD_CPUMASK_LEN); > + if (virParseCpuSet(conn, (const char **)&set, > + 0, def->cpumask, > + QEMUD_CPUMASK_LEN) < 0) { > + qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, > + "%s", _("malformed vcpu mask information")); > + goto error; > + } > + } > + xmlXPathFreeObject(obj); virXPathString() would make it way cleaner IMHO

Patch looks fine. Since we have migration nearly ready, it would be interesting to check the combination of both at some point too, Looks fine to me, +1,