Re: [libvirt] [PATCH V4 2/3] tests: Tests for the xen-xl parser
Eric Blake wrote:
On 01/13/2015 08:53 AM, Jim Fehlig wrote:
> From: Kiarie Kahurani <davidkiarie4(a)gmail.com>
>
> add tests for the xen_xl config parser
>
> Signed-off-by: Kiarie Kahurani <davidkiarie4(a)gmail.com>
> Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
> ---
>
> V4:
> Only build xlconfigtest when libxl is available.
>
>
> @@ -227,6 +228,11 @@ if WITH_XEN
> test_programs += xml2sexprtest sexpr2xmltest \
> xmconfigtest xencapstest statstest reconnect
> endif WITH_XEN
> +
> +if WITH_LIBXL
> +test_programs += xlconfigtest
> +endif WITH_LIBXL
>
Nice.
> +
> + DO_TEST("new-disk", 3);
> +// DO_TEST("spice", 3);
> +
>
Do we still need this comment?
Wow, I can't believe I missed that. Thanks for catching it. This
series is quite old and I forgot about this todo item. Enabling the
spice test not only exposed problems with the xlconfigdata test files,
but caught a bug in the xen-xl parser too! I'll fix those in V5 after
seeing your answer to my question in 1/3.
Regards,
Jim