On Thu, 2020-04-09 at 06:23 +0200, Erik Skultety wrote:
+++ b/guests/playbooks/update/tasks/gitlab.yml +- name: Make {{ gitlab_runner_config_dir }} world readable + file: + path: '{{ gitlab_runner_config_dir }}' + mode: '0755' + +- name: Make {{ gitlab_runner_config_dir }}/config.toml world readable + file: + path: '{{ gitlab_runner_config_dir }}/config.toml' + mode: '0644'
The message for these tasks is unnecessarily detailed: I'd just use something like Make gitlab-runner configuration readable for both. Additionally, even though the gitlab user is going to be the only one on the system so it doesn't make much of a difference in practice, I think we should have config.toml owner: root group: gitlab mode: '0640'
+- block: + - name: Install the gitlab_runner rc service script + template: + src: '{{ playbook_base }}/templates/gitlab-runner.j2' + dest: '/usr/local/etc/rc.d/gitlab_runner' + mode: '0755' + + - name: Enable the gitlab-runner rc service + service: + name: gitlab_runner + state: started + enabled: yes + when: ansible_service_mgr != 'systemd' +
This blank line is unnecessary and 'git am' complains about it: .git/rebase-apply/patch:83: new blank line at EOF. + With that taken care of and config.toml's permissions adjusted, Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization