Re: [libvirt] [PATCH 04/10] storage_driver: Resolve Coverity REVERSE_INULL

On 08/27/14 15:51, John Ferlan wrote:

There were two occurrances of attempting to initialize actualType by calling virStorageSourceGetActualType(src) prior to a check if (!src) resulting in Coverity complaining about the possible NULL dereference in virStorageSourceGetActualType() of src.

Resolve by moving the actualType setting until after checking !src

Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/storage/storage_driver.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)

ACK, safe for 1.2.8 Peter