On Fri, Jun 15, 2018 at 09:06:52AM +0200, Andrea Bolognani wrote:
These have been generated from the build dependency data
available in the libvirt-jenkins-ci repository, and will
be refreshed periodically to keep them in sync the same
way we've updated .travis.yml so far; my guess, based on
that effort, is that we'll need to do so about once per
release.
Automated builds will be set up on Docker Hub so that
changes to the Dockerfiles will cause the images to be
regenerated, and with that in place (a subset of) the
resulting images will be used in the Travis CI pipeline,
as well of course as being available to developers for
testing and debugging purposes.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
POC script used to generate the files:
https://www.redhat.com/archives/libvir-list/2018-June/msg01238.html
Preview of what the images will look like:
https://hub.docker.com/r/andreabolognani/buildenv-centos-7/
https://hub.docker.com/r/andreabolognani/buildenv-fedora-rawhide/
https://hub.docker.com/r/andreabolognani/buildenv-ubuntu-18/
libvirt.git feels like a sensible enough place to store these
files, especially considering that we've been storing pretty
much the same information in .travis.yml up until now; that
said, I don't love the idea of tracking what is ultimately
generated data, so I'm open to creating a separate, ad-hoc
repository (libvirt-dockerfiles.git?) instead.
They really should be just generated directly by a script in
the libvirt-jenkins-ci repo, we don't need to check the
generated files into git anywhere IMHO.
But for short term, this patch is fine.
.docker/buildenv-centos-7.Dockerfile | 70 ++++++++++++++
.docker/buildenv-debian-8.Dockerfile | 76 +++++++++++++++
.docker/buildenv-debian-9.Dockerfile | 78 ++++++++++++++++
.docker/buildenv-debian-sid.Dockerfile | 78 ++++++++++++++++
.docker/buildenv-fedora-27.Dockerfile | 78 ++++++++++++++++
.docker/buildenv-fedora-28.Dockerfile | 78 ++++++++++++++++
.docker/buildenv-fedora-rawhide.Dockerfile | 102 +++++++++++++++++++++
.docker/buildenv-ubuntu-16.Dockerfile | 79 ++++++++++++++++
.docker/buildenv-ubuntu-18.Dockerfile | 79 ++++++++++++++++
Please put them in build-aux/docker, rather than a hidden
directory.
If that is changed:
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
Regards,
Daniel
--
|:
https://berrange.com -o-
https://www.flickr.com/photos/dberrange :|
|:
https://libvirt.org -o-
https://fstop138.berrange.com :|
|:
https://entangle-photo.org -o-
https://www.instagram.com/dberrange :|