Re: [libvirt] [PATCH] qemu: make monitor command API available during async jobs
On Wed, Jun 22, 2016 at 16:17:50 +0300, Nikolay Shirokovskiy wrote:
One can not issue monitor commands manually during async calls
thru
designated API while this could be useful for testing/debugging purposes.
qemuDomainQemuMonitorCommand uses job of type QEMU_JOB_MODIFY and any async
call disable parallel execution of this type of job. The only state that is
changed is taint variable. AFAIU the only place we can mess is resetting
taint flag in qemuProcessStop routine under some async job. But this can not
happen thanx to both virDomainObjIsActive check in qemuDomainQemuMonitorCommand
and resetting active status in qemuProcessStop before taint flag.
Change job type to QEMU_JOB_QUERY and thus make the API call available for
most of async jobs.
The reason for acquiring MODIFY job is that qemuDomainQemuMonitorCommand
can be used to call any monitor command even those that modify state.
For example, you could unplug a device during an async job. And since we
don't want anything to mess up with a domain while async job is running,
acquiring just QUERY job would be wrong.
So NACK from me.
If there is a useful querying command that you need to call, we should
just add a proper API for it.
If it's all just about testing/debugging and you perhaps even want to
modify the domain at that time, you can just create a monitor proxy
which you can stick between libvirt and qemu and then you can inject any
monitor command you wish. Or you could even inject artificial monitor
events to libvirt. A long time ago I wrote such proxy, but since the
reviewers requested some changes (which I didn't have time to do and I
even thought they were not necessary) it was never pushed to libvirt's
git. I guess I could just update a bit and repost. In the meantime, feel
free to look at it or even play with it.
The original post:
https://www.redhat.com/archives/libvir-list/2011-July/msg00028.html
The git tree with monitor-proxy last time I rebased it:
https://gitlab.com/jirkade/libvirt/commits/monitor-proxy
Jirka