Re: [libvirt] [PATCH] rng: restrict passthrough names to known-good files

Eric Blake <eblake(a)redhat.com&gt; writes: > There is some controversy[1] on the qemu list on whether qemu should > have ever allowed arbitrary file name passthrough, or whether it > should be restricted to JUST /dev/random and /dev/hwrng. It is > always easier to add support for additional filenames than it is > to remove support for something once released, so this patch > restricts libvirt 1.0.3 (where the virtio-random backend was first > supported) to just the two uncontroversial names, letting us defer > to a later date any decision on whether supporting arbitrary files > makes sense. Additionally, since qemu 1.4 does NOT support > /dev/fdset/nnn fd passthrough for the backend, limiting to just > two known names means that we don't get tempted to try fd > passthrough where it won't work. Acked-by: Anthony Liguori <aliguori(a)us.ibm.com&gt;