On Fri, Nov 15, 2013 at 06:44:02PM +0100, Martin Wilck wrote:
The error message "XML error: bridge stp shold be on or off got yes" is displayed after configuring a bridge interface with NetworkManager (Fedora 19).
Reported as: https://bugzilla.redhat.com/show_bug.cgi?id=1031053
Problem description from BZ:
Steps to Reproduce: 1. create bridge configuration with NetworkManager 2. run virt-manager and open "Network Interfaces" tab in localhost connection details, or run virt-install
Actual results: "XML error: bridge stp shold be on or off got yes"
Expected results: No error message
Additional info: NM puts "yes" or "no" in the ifcfg file depending on the user STP setting:
# grep STP /etc/sysconfig/network-scripts/ifcfg-br0 STP=no
the brctl tool accepts both "on"/"off" and "yes"/"no". But libvirt handles only "on" and "off".
The XML schema does not care what values the brctl tool exposes. It standardizes on on & off for values. Whatever tool is creating this XML (netcf I guess) should translate from the values brctl uses to what the XML requires. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|