v1 here:
http://www.redhat.com/archives/libvir-list/2015-June/msg00814.html
Changes since v1:
- Add doc patch 1 to indicate that this feature may only be supported by
certain kernels
- Adjust former patch 1 to add call to qemuIsSharedHostdev from
qemuSetUnprivSGIO
- Insert patches 7 & 8 which essentially refactor qemuSetUnprivSGIO a bit.
There should be no functional difference
- Patch 9 is now a much slimmer former patch 6
The end result is that 'generically speaking' if any kernel supports
setting the unprivileged SGIO feature, then these patches provide
the capability to do so.
Although as pointed out in the review of v1 only one specific downstream
kernel supports the feature, that doesn't mean other distros couldn't add
support in the same manner. So rather than just remove all traces from
libvirt completely, it seems it would be reasonable to keep the checks
in place and if a kernel then decides to add support this code exists
to assist.
John Ferlan (10):
docs: Clarify unprivileged sgio feature for host devices
qemu: Introduce qemuIsSharedHostdev
qemu: Introduce qemuGetHostdevPath
qemu: Refactor qemuCheckSharedDisk to create virCheckUnprivSGIO
qemu: Refactor qemuAddSharedHostdev and qemuRemoveSharedHostdev
qemu: Extract qemuGetHostdevPath from qemuGetSharedHostdevKey
qemu: Refactor qemuSetUnprivSGIO return values
qemu: Fix integer/boolean logic in qemuSetUnprivSGIO
qemu: Add ability to set sgio values for hostdev
qemu: Add check for unpriv sgio for SCSI generic host device
docs/formatdomain.html.in | 7 +-
src/qemu/qemu_conf.c | 226 ++++++++++++++++++++++++++++++----------------
2 files changed, 154 insertions(+), 79 deletions(-)
--
2.1.0