Re: [Libvir] don't use virBufferAdd with string literals

Jim Meyering wrote:

I noticed a little glitch here:

src/xml.c: virBufferAdd(buf, "(usbdevice tablet)", 13); src/xml.c: virBufferAdd(buf, "(usbdevice tablet)", 18);

Ouch, that's a "how did that ever work". I see from that patch that you know about passing -1 as the length, in which case virBufferAdd will use strlen. Of course that's a redundant run-time strlen, as opposed to a compile-time sizeof. +1 to the patch. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903