RE: [RFC PATCH v3 4/6] qemucapabilitiestest: Adds Arm CCA support

On Tue, May 20, 2025 at 17:28:26 +0900, Kazuhiro Abe wrote: > From: Akio Kakuno <fj3333bs(a)fujitsu.com&gt; > > - This test was added to check qemu capabilities for Arm > CCA support. IF > This test was created using the method described in the > documentation. > > Signed-off-by: Kazuhiro Abe <fj1078ii(a)aa.jp.fujitsu.com&gt; > --- > .../caps_9.1.0_aarch64.replies | 36222 ++++++++++++++++ > .../caps_9.1.0_aarch64.xml | 530 + > 2 files changed, 36752 insertions(+) > create mode 100644 > tests/qemucapabilitiesdata/caps_9.1.0_aarch64.replies > create mode 100644 tests/qemucapabilitiesdata/caps_9.1.0_aarch64.xml Note that I'll be commenting only on the capability testing related matter, not the rest of the series. > diff --git a/tests/qemucapabilitiesdata/caps_9.1.0_aarch64.replies > b/tests/qemucapabilitiesdata/caps_9.1.0_aarch64.replies > new file mode 100644 > index 0000000000..906a21f0c6 > --- /dev/null > +++ b/tests/qemucapabilitiesdata/caps_9.1.0_aarch64.replies > @@ -0,0 +1,36222 @@ > +{ > + "execute": "qmp_capabilities", > + "id": "libvirt-1" > +} > + > +{ > + "return": {}, > + "id": "libvirt-1" > +} > + > +{ > + "execute": "query-version", > + "id": "libvirt-2" > +} > + > +{ > + "return": { > + "qemu": { > + "micro": 91, > + "minor": 1, > + "major": 9 This is from 9.2.0-rc1. So firstly the file is named wrong, because it was supposed to be 'caps_9.2.0_aarch64.replies' instead. Also except for the currently developed release we require that the .replies files are generated from the final release versions and not the RCs or any other non-final code. The libvirt tree already has qemu caps for 9.2.0 and 10.0.0 for aarch64. What makes these special? If there's a reason to have specific capabilities please add a 'variant' per tests/qemucapabilitiesdata/README.rst